[LUCENE-9856] Improve static analysis to catch dead code and other potential bugs

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.0
• Component/s: general/build
• Labels: build
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Zach Chen
• Created: 22/Mar/21 03:17
• Updated: 28/Aug/22 16:18
• Resolved: 24/Mar/21 19:53

Description

When working on PR https://github.com/apache/lucene/pull/25, we noticed that some dead code is not being caught during static analysis in gradle build, such as the start variable in the following code: https://github.com/apache/lucene/blob/a5996dbecd4a6b4147d961260711a2cb6aeab3d3/lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java#L446-L456 

We may need to look at if additional javac compiler flag, or configuration for error prone, should be added to catch such bug as well as other potential ones.

Issue Links

• is cloned by: LUCENE-9864 Enforce @Override annotation with ecj static analysis configuration
• links to: GitHub Pull Request #34
• links to: GitHub Pull Request #37
• links to: GitHub Pull Request #38