[LUCENE-9822] Assert that ForUtil.BLOCK_SIZE can be encoded in a single byte in PForUtil

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 9.0
• Fix Version/s: 9.0
• Component/s: core/codecs
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Greg Miller
• Created: 04/Mar/21 14:19
• Updated: 28/Aug/22 16:17
• Resolved: 05/Mar/21 00:00

Description

PForUtil assumes that ForUtil.BLOCK_SIZE can be encoded in a single byte when generating "patch offsets". If this assumption doesn't hold, PForUtil will silently encode incorrect positions. While the BLOCK_SIZE isn't particularly configurable, it would be nice to assert this assumption early in PForUtil in the even that the BLOCK_SIZE changes in some future codec version.