[LUCENE-9646] Set BM25Similarity discountOverlaps via the constructor

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 9.0
• Fix Version/s: 9.0
• Component/s: core/search
• Lucene Fields: New
• Assignee: Bruno Roustant
• Reporter: Patrick Marty
• Created: 21/Dec/20 17:50
• Updated: 22/Nov/24 09:49
• Resolved: 19/Jan/21 08:53

Description

BM25Similarity discountOverlaps parameter is true by default.

It can be set with org.apache.lucene.search.similarities.BM25Similarity#setDiscountOverlaps method.

But this method makes BM25Similarity mutable.

 

discountOverlaps should be set via the constructor and setDiscountOverlaps method should be removed to make BM25Similarity immutable.

 

PR https://github.com/apache/lucene-solr/pull/2161

Issue Links

• links to: GitHub Pull Request #2161