[LUCENE-9628] Make sure to account for ScoreMode.TOP_DOCS in queries

• Type: Test
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: core/search
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Julie Tibshirani
• Created: 01/Dec/20 23:05
• Updated: 28/Aug/22 16:11

Description

I noticed a few places where we are directly check the ScoreMode type that should perhaps be generalized. These could affect whether numeric sort optimization is applied:

• In BooleanWeight#bulkScorer, we check if score mode is TOP_SCORES and if so, force non-bulk scoring. Should we expand this to include modes like TOP_DOCS?
• In ConstantScoreQuery, we create the delegate weight with a hardcoded COMPLETE_NO_SCORES. I'm not sure it actually causes problems, but it seems like this doesn't handle TOP_DOCS correctly.

Apologies this issue isn’t more precise – I am not up-to-speed on the numeric sort optimization but wanted to raise these in case they’re helpful.

Issue Links

• links to: GitHub Pull Request #2126