Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-9616

Improve test coverage for internal format versions

    XMLWordPrintableJSON

Details

    • Test
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • None
    • None
    • None
    • New

    Description

      Some formats use an internal versioning system – for example CompressingStoredFieldsFormat maintains older logic for reading an on-heap fields index. Because we always allow reading segments from the current + previous major version, some users still rely on the read-side logic of older internal versions.

      Although the older version logic is covered by TestBackwardsCompatibility, it looks like it's not exercised in unit tests. Older versions aren't "in rotation" when choosing a random codec for tests. They also don't have dedicated unit tests as we have for separate older formats, for example TestLucene60PointsFormat.

      It could be good to improve unit test coverage for the older versions, since they're in active use. A downside is that it's not straightforward to add unit tests, since we tend to just change/ delete the old write-side logic as we bump internal versions.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              jtibshirani Julie Tibshirani
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 20m
                  1h 20m