[LUCENE-9453] DocumentWriterFlushControl missing explicit sync on write

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 9.0
• Component/s: core/index
• Assignee: Mike Drob
• Reporter: Mike Drob
• Created: 10/Aug/20 22:45
• Updated: 24/Nov/24 04:22
• Resolved: 11/Aug/20 15:43

Description

checkoutAndBlock is not synchronized, but has a non-atomic write to numPending. Meanwhile, all of the other writes to numPending are in sync methods.

In this case it turns out to be ok because all of the code paths calling this method are already sync:

synchronized doAfterDocument -> checkout -> checkoutAndBlock
checkoutLargestNonPendingWriter -> synchronized(this) -> checkout -> checkoutAndBlock

If we make synchronized checkoutAndBlock that protects us against future changes, shouldn't cause any performance impact since the code paths will already be going through a sync block, and will make an IntelliJ warning go away.

Issue Links

• links to: GitHub Pull Request #1734