[LUCENE-9387] Remove RAM accounting from LeafReader

• Type: Improvement
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 9.0
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Adrien Grand
• Created: 28/May/20 14:02
• Updated: 28/Aug/22 16:03
• Resolved: 14/Apr/21 12:39

Description

Context for this issue can be found at https://lists.apache.org/thread.html/r06b6a63d8689778bbc2736ec7e4e39bf89ae6973c19f2ec6247690fd%40%3Cdev.lucene.apache.org%3E.

RAM accounting made sense when readers used lots of memory. E.g. when norms were on heap, we could return memory usage of the norms array and memory estimates would be very close to actual memory usage.

However nowadays, readers consume very little memory, so RAM accounting has become less valuable. Furthermore providing good estimates has become incredibly complex as we can no longer focus on a couple main contributors to memory usage, but would need to start considering things that we historically ignored, such as field infos, segment infos, NIOFS buffers, etc.

Let's remove RAM accounting from LeafReader?

Issue Links

• breaks: SOLR-15339 Remove references to CodecReader#ramBytesUsed
• links to: GitHub Pull Request #79