Details

    • New Feature
    • Status: Reopened
    • Major
    • Resolution: Fixed
    • None
    • 9.0
    • modules/analysis
    • None
    • New

    Description

      My colleague and myself developed snowball stemmer for Serbian language recently:

      https://github.com/snowballstem/snowball/blob/master/algorithms/serbian.sbl

       

      https://snowballstem.org/algorithms/serbian/stemmer.html

      We have a Serbian Lucene analyzer developed on top of that stemmer, and we would like to make a contribution to Lucene.

      Attachments

        1. LUCENE-9313.patch
          10 kB
          Dragan Ivanovic

        Activity

          dragan.ivanovic Dragan Ivanovic created issue -
          dragan.ivanovic Dragan Ivanovic made changes -
          Field Original Value New Value
          Description My colleague and myself developed snowball stemmer for Serbian language recently:

          [https://github.com/snowballstem/snowball/blob/master/algorithms/serbian.sb]

           

          [https://snowballstem.org/algorithms/serbian/stemmer.html]

          We have a Serbian Lucene analyzer developed on top of that stemmer, and we would like to make a contribution to Lucene.
          My colleague and myself developed snowball stemmer for Serbian language recently:

          [https://github.com/snowballstem/snowball/blob/master/algorithms/serbian.sbl|https://github.com/snowballstem/snowball/blob/master/algorithms/serbian.sb]

           

          [https://snowballstem.org/algorithms/serbian/stemmer.html]

          We have a Serbian Lucene analyzer developed on top of that stemmer, and we would like to make a contribution to Lucene.
          dragan.ivanovic Dragan Ivanovic made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          dragan.ivanovic Dragan Ivanovic made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          dragan.ivanovic Dragan Ivanovic made changes -
          Attachment LUCENE-9313.patch [ 13010212 ]
          dragan.ivanovic Dragan Ivanovic made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]

          Commit c7029b12541d908e9c86f1f9946a3369aea5236a in lucene-solr's branch refs/heads/master from Robert Muir
          [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=c7029b1 ]

          LUCENE-9313: Analyzer for Serbian language based on Snowball stemmer

          jira-bot ASF subversion and git services added a comment - Commit c7029b12541d908e9c86f1f9946a3369aea5236a in lucene-solr's branch refs/heads/master from Robert Muir [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=c7029b1 ] LUCENE-9313 : Analyzer for Serbian language based on Snowball stemmer

          Commit 54a5dc2e6e3ba3e62c54805ef5621e7757e1a7bc in lucene-solr's branch refs/heads/master from Robert Muir
          [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=54a5dc2 ]

          LUCENE-9313: move change to 9.0, the prerequisite snowball support is only present there

          jira-bot ASF subversion and git services added a comment - Commit 54a5dc2e6e3ba3e62c54805ef5621e7757e1a7bc in lucene-solr's branch refs/heads/master from Robert Muir [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=54a5dc2 ] LUCENE-9313 : move change to 9.0, the prerequisite snowball support is only present there
          rcmuir Robert Muir added a comment -

          Thank you Dragan Ivanovic for this contribution!

          rcmuir Robert Muir added a comment - Thank you Dragan Ivanovic for this contribution!
          rcmuir Robert Muir made changes -
          Fix Version/s master (9.0) [ 12344814 ]
          Resolution Fixed [ 1 ]
          Status Patch Available [ 10002 ] Resolved [ 5 ]

          Thank you Robert Muir. I would like that SerbianAnalyzer is also available in Solr. I have noticed that I should modify solr/build.xml in order to copy Serbian stopwords file. However, precommit is configured by default to fail on modified files. Should I modify that file, turn of the flag failOnModified in precommit gradle task, and create new patch file? Or you have some automatic script which add all analyzers from lucene to be supported in Solr? Thanks! 

          dragan.ivanovic Dragan Ivanovic added a comment - Thank you Robert Muir . I would like that SerbianAnalyzer is also available in Solr. I have noticed that I should modify solr/build.xml in order to copy Serbian stopwords file. However, precommit is configured by default to fail on modified files. Should I modify that file, turn of the flag failOnModified in precommit gradle task, and create new patch file? Or you have some automatic script which add all analyzers from lucene to be supported in Solr? Thanks! 
          rcmuir Robert Muir added a comment -

          Dragan Ivanovic As you mentioned, yes there is a sync-analyzers target in the solr/build.xml based on ant. But I don't know if there is a gradle equivalent to this.

          As far as the modified-files check, I simply do git add to stage all of my modifications before running the precommit check.

          rcmuir Robert Muir added a comment - Dragan Ivanovic As you mentioned, yes there is a sync-analyzers target in the solr/build.xml based on ant. But I don't know if there is a gradle equivalent to this. As far as the modified-files check, I simply do git add to stage all of my modifications before running the precommit check.
          erickerickson Erick Erickson added a comment -

          Dragan Ivanovic Currently things are a bit confusing, we're supporting both Ant and Gradle on 9x. build.xml should be irrelevant to the Gradle build as it's part of the Ant build and will be removed Real Soon Now.

          We're just about to remove ant support totally, so we can ignore the ant bits.

          Meanwhile, "./gradlew check -x test" passes for me, so I assume you are trying to update locally. If you provide a patch or PR maybe I can help figure it out. Perhaps this should be a new Jira though, something like "Make SerbianAnalyzer available to Solr"?

          And I'll add my thanks to Robert's, this is how open source grows...

          erickerickson Erick Erickson added a comment - Dragan Ivanovic Currently things are a bit confusing, we're supporting both Ant and Gradle on 9x. build.xml should be irrelevant to the Gradle build as it's part of the Ant build and will be removed Real Soon Now. We're just about to remove ant support totally, so we can ignore the ant bits. Meanwhile, "./gradlew check -x test" passes for me, so I assume you are trying to update locally. If you provide a patch or PR maybe I can help figure it out. Perhaps this should be a new Jira though, something like "Make SerbianAnalyzer available to Solr"? And I'll add my thanks to Robert's, this is how open source grows...

          Ok, thank you both Robert Muir Erick Erickson. I will check it once again and if it is necessary open the new issue for SerbianAnalyzer for Solr. Unfortunately, I can't work on it in the next 10 days. 

          dragan.ivanovic Dragan Ivanovic added a comment - Ok, thank you both Robert Muir Erick Erickson . I will check it once again and if it is necessary open the new issue for SerbianAnalyzer for Solr. Unfortunately, I can't work on it in the next 10 days. 
          erickerickson Erick Erickson added a comment -

          Feel free to put up what you have now if it's failing Gradle, just add a note that that's the case. I'll have a chance to look at it while you're busy. If it's something simple I could push it as well. Up to you...

          erickerickson Erick Erickson added a comment - Feel free to put up what you have now if it's failing Gradle, just add a note that that's the case. I'll have a chance to look at it while you're busy. If it's something simple I could push it as well. Up to you...

          Commit 54a5dc2e6e3ba3e62c54805ef5621e7757e1a7bc in lucene-solr's branch refs/heads/datcm/bloomberg-abdicate-leadership from Robert Muir
          [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=54a5dc2 ]

          LUCENE-9313: move change to 9.0, the prerequisite snowball support is only present there

          jira-bot ASF subversion and git services added a comment - Commit 54a5dc2e6e3ba3e62c54805ef5621e7757e1a7bc in lucene-solr's branch refs/heads/datcm/bloomberg-abdicate-leadership from Robert Muir [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=54a5dc2 ] LUCENE-9313 : move change to 9.0, the prerequisite snowball support is only present there

          Commit 54a5dc2e6e3ba3e62c54805ef5621e7757e1a7bc in lucene-solr's branch refs/heads/datcm/bloomberg-abdicate-leadership from Robert Muir
          [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=54a5dc2 ]

          LUCENE-9313: move change to 9.0, the prerequisite snowball support is only present there

          jira-bot ASF subversion and git services added a comment - Commit 54a5dc2e6e3ba3e62c54805ef5621e7757e1a7bc in lucene-solr's branch refs/heads/datcm/bloomberg-abdicate-leadership from Robert Muir [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=54a5dc2 ] LUCENE-9313 : move change to 9.0, the prerequisite snowball support is only present there
          jpountz Adrien Grand added a comment -

          Closing after the 9.0.0 release

          jpountz Adrien Grand added a comment - Closing after the 9.0.0 release
          jpountz Adrien Grand made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          tomoko Tomoko Uchida added a comment -

          This issue was moved to GitHub issue: #10353.

          tomoko Tomoko Uchida added a comment - This issue was moved to GitHub issue: #10353 .
          Anonymous made changes -
          Status Closed [ 6 ] Reopened [ 4 ]

          People

            Unassigned Unassigned
            dragan.ivanovic Dragan Ivanovic
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack