Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-9080

Upgrade ICU4j to 62.2 and make regenerate work

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 9.0
    • None
    • None
    • New

    Description

      The root cause is that RamUsageEstimator.NUM_BYTES_INT has been removed and the python scripts still reference it in the generated scripts. That part's easy to fix.

      Last time I looked, though, the regenerate produces some differences in the generated files that should be looked at to insure they're benign.

      Not really sure whether this should be a Lucene or Solr JIRA. Putting it in Lucene since one of the failed files is: lucene/core/src/java/org/apache/lucene/util/packed/Packed8ThreeBlocks.java

      I do know that one of the Solr jflex-produced file has an unexplained difference so it may bleed over.

      "ant regenerate" needs about 24G on my machine FWIW.

      Attachments

        1. status.res
          5 kB
          Erick Erickson
        2. before_regen.patch
          4 kB
          Erick Erickson
        3. after_regen.patch
          4.21 MB
          Erick Erickson

        Issue Links

          Activity

            People

              dweiss Dawid Weiss
              erickerickson Erick Erickson
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h