Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-9026

Make it easier to extend DocValuesTermsQuery

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: master (9.0)
    • Fix Version/s: master (9.0), 8.4
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The visibility of some of the fields in DocValuesTermsQuery make it difficult to efficiently subclass. Especially the "termData" instance variable, which is really core to the functioning of the class but is totally inaccessible from any sub-classes, forcing subclasses to store a duplicate PrefixCodedTerms object, and then juggle the state of both.

      Are there any objections to making "termData" (and potentiall some other instance variables) protected instead of private for this class?

        Attachments

        1. LUCENESOLR-9026.patch
          1 kB
          Jason Gerlowski

          Activity

            People

            • Assignee:
              gerlowskija Jason Gerlowski
              Reporter:
              gerlowskija Jason Gerlowski
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: