Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8811

Add maximum clause count check to IndexSearcher rather than BooleanQuery

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 9.0
    • None
    • None
    • New

    Description

      Currently we only check whether boolean queries have too many clauses. However there are other ways that queries may have too many clauses, for instance if you have boolean queries that have themselves inner boolean queries.

      Could we use the new Query visitor API to move this check from BooleanQuery to IndexSearcher in order to make this check more consistent across queries? See for instance LUCENE-8810 where a rewrite rule caused the maximum clause count to be hit even though the total number of leaf queries remained the same.

      Attachments

        1. LUCENE-8811.patch
          7 kB
          Atri Sharma
        2. LUCENE-8811.patch
          68 kB
          Atri Sharma
        3. LUCENE-8811.patch
          68 kB
          Atri Sharma
        4. LUCENE-8811.patch
          7 kB
          Atri Sharma
        5. LUCENE-8811.patch
          66 kB
          Atri Sharma
        6. LUCENE-8811.patch
          67 kB
          Atri Sharma

        Issue Links

          is related to

          Task - A task that needs to be done. SOLR-15429 Solr implications of LUCENE-8811 changes to how (solr.xml's) maxBooleanClauses is now used by IndexSearcher

          • Major - Major loss of function.
          • Closed

          Activity

            People

              romseygeek Alan Woodward
              jpountz Adrien Grand
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: