[LUCENE-8712] Polygon2D does not detect crossings in some cases

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.x, 9.0
• Lucene Fields: New
• Assignee: Ignacio Vera
• Reporter: Ignacio Vera
• Created: 28/Feb/19 16:18
• Updated: 28/Aug/22 15:42
• Resolved: 12/Mar/19 07:56

Description

Polygon2D does not detect crossing if the triangle crosses through points of the polygon and none of the points are inside it. For example:

 

public void testLineCrossingPolygonPoints() {
  Polygon p = new Polygon(new double[] {0, -1, 0, 1, 0}, new double[] {-1, 0, 1, 0, -1});
  Polygon2D polygon2D = Polygon2D.create(p);
  PointValues.Relation rel = polygon2D.relateTriangle(GeoEncodingUtils.decodeLongitude(GeoEncodingUtils.encodeLongitude(-1.5)),
      GeoEncodingUtils.decodeLatitude(GeoEncodingUtils.encodeLatitude(0)),
      GeoEncodingUtils.decodeLongitude(GeoEncodingUtils.encodeLongitude(1.5)),
      GeoEncodingUtils.decodeLatitude(GeoEncodingUtils.encodeLatitude(0)),
      GeoEncodingUtils.decodeLongitude(GeoEncodingUtils.encodeLongitude(-1.5)),
      GeoEncodingUtils.decodeLatitude(GeoEncodingUtils.encodeLatitude(0)));
  assertEquals(PointValues.Relation.CELL_CROSSES_QUERY, rel);
}

nknize you might want to look at this as I am not sure what to do.

Issue Links

• links to: GitHub Pull Request #598