Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 8.x, 9.0
    • None
    • None
    • New

    Description

      This proposal moves all the spatial logic for a component to Polygon2D and Line2D. It improves readability of how each object behaves.

      Attachments

        1. LUCENE-8680.patch
          9 kB
          Ignacio Vera

        Activity

          lucenesolrqa Lucene/Solr QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
                Prechecks
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                master Compile Tests
          +1 compile 0m 44s master passed
                Patch Compile Tests
          +1 compile 0m 40s the patch passed
          +1 javac 0m 40s the patch passed
          +1 Release audit (RAT) 0m 35s the patch passed
          +1 Check forbidden APIs 0m 30s the patch passed
          +1 Validate source patterns 0m 30s the patch passed
                Other Tests
          +1 unit 15m 6s core in the patch passed.
          +1 unit 1m 49s sandbox in the patch passed.
          20m 49s



          Subsystem Report/Notes
          JIRA Issue LUCENE-8680
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12957605/LUCENE-8680.patch
          Optional Tests compile javac unit ratsources checkforbiddenapis validatesourcepatterns
          uname Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
          Build tool ant
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
          git revision master / 1d13d3d
          ant version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018
          Default Java 1.8.0_191
          Test Results https://builds.apache.org/job/PreCommit-LUCENE-Build/162/testReport/
          modules C: lucene/core lucene/sandbox U: lucene
          Console output https://builds.apache.org/job/PreCommit-LUCENE-Build/162/console
          Powered by Apache Yetus 0.7.0 http://yetus.apache.org

          This message was automatically generated.

          lucenesolrqa Lucene/Solr QA added a comment - -1 overall Vote Subsystem Runtime Comment       Prechecks -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       master Compile Tests +1 compile 0m 44s master passed       Patch Compile Tests +1 compile 0m 40s the patch passed +1 javac 0m 40s the patch passed +1 Release audit (RAT) 0m 35s the patch passed +1 Check forbidden APIs 0m 30s the patch passed +1 Validate source patterns 0m 30s the patch passed       Other Tests +1 unit 15m 6s core in the patch passed. +1 unit 1m 49s sandbox in the patch passed. 20m 49s Subsystem Report/Notes JIRA Issue LUCENE-8680 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12957605/LUCENE-8680.patch Optional Tests compile javac unit ratsources checkforbiddenapis validatesourcepatterns uname Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Build tool ant Personality /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh git revision master / 1d13d3d ant version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 Default Java 1.8.0_191 Test Results https://builds.apache.org/job/PreCommit-LUCENE-Build/162/testReport/ modules C: lucene/core lucene/sandbox U: lucene Console output https://builds.apache.org/job/PreCommit-LUCENE-Build/162/console Powered by Apache Yetus 0.7.0 http://yetus.apache.org This message was automatically generated.
          nknize Nick Knize added a comment -

          +1 Thanks ivera!

          nknize Nick Knize added a comment - +1 Thanks ivera !

          Commit 06c1ebc09e1d39e3d556dc97392a565466fca9d5 in lucene-solr's branch refs/heads/master from Ignacio Vera
          [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=06c1ebc ]

          LUCENE-8680: Refactor EdgeTree#relateTriangle method

          jira-bot ASF subversion and git services added a comment - Commit 06c1ebc09e1d39e3d556dc97392a565466fca9d5 in lucene-solr's branch refs/heads/master from Ignacio Vera [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=06c1ebc ] LUCENE-8680 : Refactor EdgeTree#relateTriangle method

          Commit d7d4d64f346136d34399226a4bf19c3eb28f45a3 in lucene-solr's branch refs/heads/branch_8x from Ignacio Vera
          [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=d7d4d64 ]

          LUCENE-8680: Refactor EdgeTree#relateTriangle method

          jira-bot ASF subversion and git services added a comment - Commit d7d4d64f346136d34399226a4bf19c3eb28f45a3 in lucene-solr's branch refs/heads/branch_8x from Ignacio Vera [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=d7d4d64 ] LUCENE-8680 : Refactor EdgeTree#relateTriangle method

          Commit 56007af4a45b1ac64cd34ced07126fff9e7f490b in lucene-solr's branch refs/heads/master from Ignacio Vera
          [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=56007af ]

          LUCENE-8680: Add CHANGES.txt entry

          jira-bot ASF subversion and git services added a comment - Commit 56007af4a45b1ac64cd34ced07126fff9e7f490b in lucene-solr's branch refs/heads/master from Ignacio Vera [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=56007af ] LUCENE-8680 : Add CHANGES.txt entry

          Commit f79c8e6cd5fba79ed554938fee4218501c297da1 in lucene-solr's branch refs/heads/branch_8x from Ignacio Vera
          [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f79c8e6 ]

          LUCENE-8680: Add CHANGES.txt entry

          jira-bot ASF subversion and git services added a comment - Commit f79c8e6cd5fba79ed554938fee4218501c297da1 in lucene-solr's branch refs/heads/branch_8x from Ignacio Vera [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f79c8e6 ] LUCENE-8680 : Add CHANGES.txt entry
          jpountz Adrien Grand added a comment -

          Closing after the 9.0.0 release

          jpountz Adrien Grand added a comment - Closing after the 9.0.0 release
          tomoko Tomoko Uchida added a comment -

          This issue was moved to GitHub issue: #9726.

          tomoko Tomoko Uchida added a comment - This issue was moved to GitHub issue: #9726 .

          People

            ivera Ignacio Vera
            ivera Ignacio Vera
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: