Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8657

CharsRef.compareTo() should always be in UTF-8 order

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: 8.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      CharsRef.compareTo() currently directly compares byte values.  However, everywhere that CharsRef objects are compared in the codebase instead uses the deprecated UTF16SortedAsUTF8Comparator static comparator.  We should just reimplement compareTo() to use UTF-8 comparisons instead, and remove the deprecated methods.

        Attachments

        1. LUCENE-8657.patch
          7 kB
          Alan Woodward

          Activity

            People

            • Assignee:
              romseygeek Alan Woodward
              Reporter:
              romseygeek Alan Woodward
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: