[LUCENE-8642] RamUsageTester.sizeOf ignores arrays and collections if --illegal-access=deny

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.0
• Lucene Fields: New
• Assignee: Dawid Weiss
• Reporter: Dawid Weiss
• Created: 16/Jan/19 10:24
• Updated: 28/Aug/22 15:40
• Resolved: 18/Jan/19 11:23

Description

We have a silent fall-through on catch clause there if a field is inaccessible. This causes all collections to not be recursively descended into.

We could hack it so that collection objects are counted "manually". Or we could propagate illegal access exception from ram tester, detect which tests/ objects do try to measure collection objects and either remove them (if it's not possible to measure accurately) or change them (if it is possible to estimate the size in a different way).

Looking for feedback on this one.

Issue Links

• blocks: LUCENE-8641 TermInSetQueryTest.testRamBytesUsed fails with an assertion on Java > 1.8
• is related to: LUCENE-7595 RAMUsageTester in test-framework and static field checker no longer works with Java 9