[LUCENE-8575] Improve toString() in SegmentInfo

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.7, 8.0
• Component/s: core/index
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Namgyu Kim
• Created: 27/Nov/18 16:32
• Updated: 13/Feb/19 17:29
• Resolved: 30/Nov/18 09:13

Description

I saw the following code in SegmentInfo class.

// TODO: we could append toString of attributes() here?

Of course, we can.

 

So I wrote a code for that part.

public String toString(int delCount) {
  StringBuilder s = new StringBuilder();
  s.append(name).append('(').append(version == null ? "?" : version).append(')').append(':');
  char cfs = getUseCompoundFile() ? 'c' : 'C';
  s.append(cfs);

  s.append(maxDoc);

  if (delCount != 0) {
    s.append('/').append(delCount);
  }

  if (indexSort != null) {
    s.append(":[indexSort=");
    s.append(indexSort);
    s.append(']');
  }

  // New Code
  if (!diagnostics.isEmpty()) {
    s.append(":[diagnostics=");
    for (Map.Entry<String, String> entry : diagnostics.entrySet())
      s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
    s.setLength(s.length() - 1);
    s.append(']');
  }

  // New Code
  if (!attributes.isEmpty()) {
    s.append(":[attributes=");
    for (Map.Entry<String, String> entry : attributes.entrySet())
      s.append("<").append(entry.getKey()).append(",").append(entry.getValue()).append(">,");
    s.setLength(s.length() - 1);
    s.append(']');
  }

  return s.toString();
}

 

Issue Links

• causes: SOLR-13246 Reduce QuerySenderListener log messages