Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8338

Ensure number returned for PendingDeletes are well defined

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.4, 8.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Today a call to PendingDeletes#numPendingDeletes might return 0
      if the deletes are written to disk. This doesn't mean these values are committed
      or refreshed in the latest reader. Some places in IW use these numbers to make
      decisions if there has been deletes added since last time checked (BufferedUpdateStream)
      which can cause wrong (while not fatal) decision ie. to kick of new merges.

      Now this API is made protected and not visible outside of PendingDeletes to prevent
      any kind of confusion. The APIs now allow to get absolute numbers of getDelCount and numDocs
      which have the same name and semantics as their relatives on IndexReader/Writer
      and SegmentCommitInfo.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              simonw Simon Willnauer

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment