Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8332

New ConcatenateGraphFilter (move/rename CompletionTokenStream)

    XMLWordPrintableJSON

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.4
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Lets move and rename the CompletionTokenStream in the suggest module into the analysis module renamed as ConcatenateGraphFilter. See comments in LUCENE-8323 leading to this idea. Such a TokenStream (or TokenFilter?) has several uses:

      • for the suggest module
      • by the SolrTextTagger for NER/ERD use cases – SOLR-12376
      • for doing complete match search efficiently

      It will need a factory – a TokenFilterFactory, even though we don't have a TokenFilter based subclass of TokenStream.

      It appears there is no back-compat concern in it suddenly disappearing from the suggest module as it's marked experimental and it only seems to be public now perhaps due to some technicality (it has package level constructors).

        Attachments

        1. LUCENE-8332.patch
          68 kB
          David Smiley
        2. LUCENE-8332.patch
          68 kB
          David Smiley
        3. LUCENE-8332.patch
          68 kB
          David Smiley

          Issue Links

            Activity

              People

              • Assignee:
                dsmiley David Smiley
                Reporter:
                dsmiley David Smiley
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 3h 20m
                  3h 20m