Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8272

Share internal DV update code between binary and numeric

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 7.4, 8.0
    • Fix Version/s: 7.4, 8.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Today we duplicate a fair portion of the internal logic to
      apply updates of binary and numeric doc values. This change refactors
      this non-trivial code to share the same code path and only differ in
      if we provide a binary or numeric instance. This also allows us to
      iterator over the updates only once rather than twice once for numeric
      and once for binary fields.

      This change also subclass DocValuesIterator from DocValuesFieldUpdates.Iterator
      which allows easier consumption down the road since it now shares most of it's
      interface with DocIdSetIterator which is the main interface for this in Lucene.

        Attachments

        1. LUCENE-8272.patch
          28 kB
          Simon Willnauer

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              simonw Simon Willnauer
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: