[LUCENE-8148] Get precommit Lint warnings out of test code

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.6
• Lucene Fields: New
• Assignee: Erick Erickson
• Reporter: Erick Erickson
• Created: 01/Feb/18 05:41
• Updated: 28/Aug/22 15:24
• Resolved: 25/Jun/20 21:27

Description

Mostly putting this up for discussion. I'm starting to work on Solr test lint warnings, it seems right to break the Lucene changes and Solr changes into separate JIRAs.

First of all, do people have objections to me mucking around in the Lucene test code to do this? The eventual goal here is to get to the point where we can turn on precommit failures on lint warnings. Deprecations maybe as well, but that's a separate issue, as is non-test code.

I expect to see a lot of pretty safe issues, then a series I'm not sure of, I'll ask when I find them if I wind up carrying this forward.

Issue Links

• is fixed by: LUCENE-9394 Fix or suppress compile-time warnings
• relates to: SOLR-10809 Get precommit lint warnings out of Solr core