[LUCENE-8077] Integer remainder modulo 1 problem in /core/src/java/org/apache/lucene/index/CheckIndex.java

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 7.1
• Fix Version/s: 7.3, 8.0
• Component/s: core/index
• Labels: easyfix
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Xiaoshan Sun
• Created: 03/Dec/17 10:52
• Updated: 28/Aug/22 15:22
• Resolved: 20/Dec/17 11:50

Description

At /core/src/java/org/apache/lucene/index/CheckIndex.java: 2198
The branch condition :

(i % 1 == 0)

is always true.
Did you mean (exp & 1) or (exp % 2) instead?

The related code is show below:

2198:        if (i % 1 == 0) {
          int doc2 = it2.nextDoc();
          if (doc != doc2) {
            throw new RuntimeException("dv iterator field=" + field + ": doc=" + doc + " was not found through advance() (got: " + doc2 + ")");
          }
          if (it2.docID() != doc) {
            throw new RuntimeException("dv iterator field=" + field + ": doc=" + doc + " reports wrong doc ID (got: " + it2.docID() + ")");
          }
        }
      }