[LUCENE-7833] Calculating minimum score instead of maximum score in ToParentBlockJoinQuery.BlockJoinScorer.setScoreAndFreq

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.6, 7.0
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Bernhard Altendorfer
• Created: 17/May/17 17:00
• Updated: 28/Aug/22 15:15
• Resolved: 19/May/17 06:33

Description

We recently upgraded our Elasticsearch cluster from 5.3 to 5.4 and found a bug when we score nested documents.

I spent some time to check the code from Elasticsearch and Lucene and I found a problem in ToParentBlockJoinQuery.BlockJoinScorer.setScoreAndFreq.

In the switch statement for the scoreMode in the case "Max" the function Math.min is used and I guess it should be Math.max.

This would explain our problem in Elasticsearch because we see exactly the problem that instead of the maximum the minimum is returned.

Issue Links

• is broken by: LUCENE-7654 To-parent block joins should implement two-phase iteration