Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0, 6.6
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New
    1. LUCENE-7754.patch
      133 kB
      Daniel Jelinski

      Activity

      Hide
      djelinski Daniel Jelinski added a comment -

      The patch should be source and binary compatible with Lucene clients, as the modified classes are not visible outside Lucene's code. ConstantScoreQuery$ConstantBulkScorer is protected, but the outer class is final. JaspellTernarySearchTrie$TSTNode is protected final. The remaining nested classes are private, package-local or test.
      There's a number of public classes with modified signatures in Solr. I'm not sure if I their signatures can be changed, if not, I may need to remove them from patch.
      There are a few more classes that could be made static after LUCENE-7753 is implemented.

      Show
      djelinski Daniel Jelinski added a comment - The patch should be source and binary compatible with Lucene clients, as the modified classes are not visible outside Lucene's code. ConstantScoreQuery$ConstantBulkScorer is protected, but the outer class is final. JaspellTernarySearchTrie$TSTNode is protected final. The remaining nested classes are private, package-local or test. There's a number of public classes with modified signatures in Solr. I'm not sure if I their signatures can be changed, if not, I may need to remove them from patch. There are a few more classes that could be made static after LUCENE-7753 is implemented.
      Hide
      jpountz Adrien Grand added a comment -

      It looks good to me. I plan on merging it except the changes to the org.egothor package since this code was copied from another project.

      Show
      jpountz Adrien Grand added a comment - It looks good to me. I plan on merging it except the changes to the org.egothor package since this code was copied from another project.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 53064e46ddfc94a0b0e1d9c9f3e94786fb6701cd in lucene-solr's branch refs/heads/master from Adrien Grand
      [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=53064e4 ]

      LUCENE-7754: Inner classes should be static whenever possible.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 53064e46ddfc94a0b0e1d9c9f3e94786fb6701cd in lucene-solr's branch refs/heads/master from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=53064e4 ] LUCENE-7754 : Inner classes should be static whenever possible.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit a6083982180979aec1f5e782378055ef78089ff9 in lucene-solr's branch refs/heads/branch_6x from Adrien Grand
      [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a608398 ]

      LUCENE-7754: Inner classes should be static whenever possible.

      Show
      jira-bot ASF subversion and git services added a comment - Commit a6083982180979aec1f5e782378055ef78089ff9 in lucene-solr's branch refs/heads/branch_6x from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a608398 ] LUCENE-7754 : Inner classes should be static whenever possible.

        People

        • Assignee:
          Unassigned
          Reporter:
          djelinski Daniel Jelinski
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development