Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0, 6.5
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available
    • Flags:
      Patch
    1. LUCENE-7742.patch
      13 kB
      Daniel Jelinski
    2. LUCENE-7742.patch
      13 kB
      Daniel Jelinski

      Issue Links

        Activity

        Hide
        djelinski Daniel Jelinski added a comment -

        Some of the ternary operator use cases don't look as good with this patch; as an alternative I could replace them with regular if/else

        Show
        djelinski Daniel Jelinski added a comment - Some of the ternary operator use cases don't look as good with this patch; as an alternative I could replace them with regular if/else
        Hide
        djelinski Daniel Jelinski added a comment -

        Rebased the patch... the old one didn't apply anymore.

        Show
        djelinski Daniel Jelinski added a comment - Rebased the patch... the old one didn't apply anymore.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 716d43eca936e3ea5325a0ee0cceb087a4ff32e5 in lucene-solr's branch refs/heads/master from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=716d43e ]

        LUCENE-7742: fix places where we were unboxing and then re-boxing according to FindBugs

        Show
        jira-bot ASF subversion and git services added a comment - Commit 716d43eca936e3ea5325a0ee0cceb087a4ff32e5 in lucene-solr's branch refs/heads/master from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=716d43e ] LUCENE-7742 : fix places where we were unboxing and then re-boxing according to FindBugs
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 02981d542c6145076ecb58f0c2e87e171fdcf64b in lucene-solr's branch refs/heads/branch_6x from Mike McCandless
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=02981d5 ]

        LUCENE-7742: fix places where we were unboxing and then re-boxing according to FindBugs

        Show
        jira-bot ASF subversion and git services added a comment - Commit 02981d542c6145076ecb58f0c2e87e171fdcf64b in lucene-solr's branch refs/heads/branch_6x from Mike McCandless [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=02981d5 ] LUCENE-7742 : fix places where we were unboxing and then re-boxing according to FindBugs
        Hide
        mikemccand Michael McCandless added a comment -

        Thanks Daniel Jelinski, I pushed this; but we still need to fold this into ant precommit somehow.

        Show
        mikemccand Michael McCandless added a comment - Thanks Daniel Jelinski , I pushed this; but we still need to fold this into ant precommit somehow.

          People

          • Assignee:
            Unassigned
            Reporter:
            djelinski Daniel Jelinski
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development