Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7716

Reduce specialization in TopFieldCollector

    XMLWordPrintableJSON

    Details

    • Type: Wish
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.5, 7.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      TopFieldCollector optimizes the single-comparator case. I think we could replace this specialization with a MultiLeafFieldComparator wrapper, similarly to how MultiCollector works. This would have the benefit of replacing code duplication of non-trivial logic with a simple wrapper that delegates calls to its sub comparators.

        Attachments

        1. LUCENE-7716.patch
          14 kB
          Adrien Grand

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jpountz Adrien Grand
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: