[LUCENE-7683] FilterScorer to override more super-class methods

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Christine Poerschke
• Created: 08/Feb/17 18:22
• Updated: 08/Feb/17 19:02

Description

Scorer.java has non-abstract non-final non-private non-static methods (getChildren, getWeight) which the FilterScorer.java class does not override.

Proposed changes:

• Option 1: Add the missing methods.
• Option 2: Make the missing methods final in the non-Filter base class.
• Either way, add TestFilterScorer.java class similar to TestFilterWeight.java class.

Optional bonus (as a separate patch?):

• TestFilterWeight, TestFilterCodecReader, TestMergePolicyWrapper and possibly other tests all have implTestDeclaredMethodsOverridden(superClass, subClass, excusedMethods) logic and some sort of lucene/test-framework util FilterTestUtils.java class with a static implTestDeclaredMethodsOverridden method could perhaps be factored out.

Issue Links

• is related to: LUCENE-7676 FilterCodecReader to override more super-class methods