Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7683

FilterScorer to override more super-class methods

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Scorer.java has non-abstract non-final non-private non-static methods (getChildren, getWeight) which the FilterScorer.java class does not override.

      Proposed changes:

      • Option 1: Add the missing methods.
      • Option 2: Make the missing methods final in the non-Filter base class.
      • Either way, add TestFilterScorer.java class similar to TestFilterWeight.java class.

      Optional bonus (as a separate patch?):

      • TestFilterWeight, TestFilterCodecReader, TestMergePolicyWrapper and possibly other tests all have implTestDeclaredMethodsOverridden(superClass, subClass, excusedMethods) logic and some sort of lucene/test-framework util FilterTestUtils.java class with a static implTestDeclaredMethodsOverridden method could perhaps be factored out.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                cpoerschke Christine Poerschke
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: