Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7649

investigate re-adding unwrapSingleton optimization attempted by LUCENE-7643

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 6.5, 7.0
    • None
    • None
    • New

    Description

      as part of some refactoring done in LUCENE-7643, an optimization for was introduced for some single valued cases, which introduced an NPE risk surfaced in SOLR-10013.

      I plan to fix SOLR-10013 by disabling this optimization with a comment pointing to this issue, and commit with it a lucene level test steve wrote that usualy fails with the optimized code (since it doesn't fail 100% of the time, it suggests the failure is related to the RandomizedIndexWriter - the docs and queries are fixed)

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jpountz Adrien Grand
            hossman Chris M. Hostetter
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment