Details
-
Type:
Wish
-
Status: Resolved
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: master (7.0)
-
Component/s: None
-
Labels:None
-
Lucene Fields:New
Description
This is a follow-up to LUCENE-7491. Maybe we could simplify things a bit by changing LeafReader.getPointValues() to LeafReader.getPointValues(String fieldName) and removing all String fieldName parameters from PointValues?
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
+1.
Related conceptually is another idea I've had kicking around: Does Fields need to exist? It seems like a pointless intermediary. Why not have LeafReader.getTerms(fieldName) instead? One loses the ability to get the count and iterate over indexed fields, but it's not clear what real use-cases are for that and such rare needs could figure that out with FieldInfos. If it sounds reasonable to you all I'll file a separate issue.
Fields does seem a bit silly, being such a tiny wrapper class, and it would make things more consistent if you also just passed a field name to the IndexReader API.
Though, we also return Fields from getTermVectors, since that's essentially a tiny single-document inverted index. I'm not sure how we'd polish that usage away ... I guess we could just narrow it to a new (old!) TermVectors class.
+1 to nuking Fields too
Here is a patch that deals with points. I'd like to do changes to Fields / term vectors in a different issue.
+1 to the patch. I like how it, at least it seems, like there is a net reduction in code.
The diff stats report a reduction of the number of lines indeed:
51 files changed, 648 insertions(+), 958 deletions(-)
+1 to the patch, thanks Adrien Grand!
Commit c22725f0b53a0d1a50cbc5a9d21ced29e6d7cd39 in lucene-solr's branch refs/heads/master from Adrien Grand
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c22725f ]
LUCENE-7494: Give points a per-field API.
+1