Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Splitting LUCENE-7347 into smaller tasks.

      1. LUCENE-7369.patch
        179 kB
        Adrien Grand

        Activity

        Hide
        jpountz Adrien Grand added a comment -

        Here is a patch. Similarity.coord and BooleanQuery.Builder.setDisableCoords are gone, which helped simplify BooleanWeight and our boolean scorers. The standard query parser had a special node for boolean queries with configurable disableCoord, which was only a way to handle synonyms in practice, so these nodes have been renamed to SynonymQueryNode (they are useful so that the default operator is not applied for boolean queries that represent synonyms). I did not change it to keep the change minimal but in the future it should probably switch to SynonymQuery. The rest of the patch is rather straightforward and just removes all calls to BooleanQuery.Builder.setDisableCoords.

        Show
        jpountz Adrien Grand added a comment - Here is a patch. Similarity.coord and BooleanQuery.Builder.setDisableCoords are gone, which helped simplify BooleanWeight and our boolean scorers. The standard query parser had a special node for boolean queries with configurable disableCoord, which was only a way to handle synonyms in practice, so these nodes have been renamed to SynonymQueryNode (they are useful so that the default operator is not applied for boolean queries that represent synonyms). I did not change it to keep the change minimal but in the future it should probably switch to SynonymQuery. The rest of the patch is rather straightforward and just removes all calls to BooleanQuery.Builder.setDisableCoords.
        Hide
        jpountz Adrien Grand added a comment -

        I will commit this patch within the next few days if there are no objections.

        Show
        jpountz Adrien Grand added a comment - I will commit this patch within the next few days if there are no objections.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f1528bf338f42ef0e10f6cf1333286eb05139acd in lucene-solr's branch refs/heads/master from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f1528bf ]

        LUCENE-7369: Similarity.coord and BooleanQuery.disableCoord are removed.

        Show
        jira-bot ASF subversion and git services added a comment - Commit f1528bf338f42ef0e10f6cf1333286eb05139acd in lucene-solr's branch refs/heads/master from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f1528bf ] LUCENE-7369 : Similarity.coord and BooleanQuery.disableCoord are removed.

          People

          • Assignee:
            jpountz Adrien Grand
            Reporter:
            jpountz Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development