Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.1, master (7.0)
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This can be useful for dealing with exclusive bounds.

      1. LUCENE-7234.patch
        6 kB
        Adrien Grand
      2. LUCENE-7234.patch
        5 kB
        Adrien Grand

        Activity

        Hide
        jpountz Adrien Grand added a comment -

        Here is a patch. It also adds MIN_VALUE/MAX_VALUE constants if consumers of these methods want to do something else than propagating the exception in case of underflow or overflow.

        Show
        jpountz Adrien Grand added a comment - Here is a patch. It also adds MIN_VALUE/MAX_VALUE constants if consumers of these methods want to do something else than propagating the exception in case of underflow or overflow.
        Hide
        rcmuir Robert Muir added a comment -

        Looks good. In most cases overflow/underflow is ArithmeticException, maybe we want it instead of IAE. Should we mention it from the newRangeQuery docs in case someone wants to do this?

        Show
        rcmuir Robert Muir added a comment - Looks good. In most cases overflow/underflow is ArithmeticException, maybe we want it instead of IAE. Should we mention it from the newRangeQuery docs in case someone wants to do this?
        Hide
        jpountz Adrien Grand added a comment -

        Here is a new patch. I added the suggested javadocs and replaced the IAE with an ArithmeticException.

        Show
        jpountz Adrien Grand added a comment - Here is a new patch. I added the suggested javadocs and replaced the IAE with an ArithmeticException.
        Hide
        rcmuir Robert Muir added a comment -

        looks good.

        Show
        rcmuir Robert Muir added a comment - looks good.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0ee2319866a3ec52a22d7c9ad15f90f4a07efeb6 in lucene-solr's branch refs/heads/branch_6x from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0ee2319 ]

        LUCENE-7234: Add InetAddressPoint.nextUp/nextDown

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0ee2319866a3ec52a22d7c9ad15f90f4a07efeb6 in lucene-solr's branch refs/heads/branch_6x from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0ee2319 ] LUCENE-7234 : Add InetAddressPoint.nextUp/nextDown
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 91fd163112b9a433d3e1f578d5c8a9cfbd9dce2f in lucene-solr's branch refs/heads/master from Adrien Grand
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=91fd163 ]

        LUCENE-7234: Add InetAddressPoint.nextUp/nextDown

        Show
        jira-bot ASF subversion and git services added a comment - Commit 91fd163112b9a433d3e1f578d5c8a9cfbd9dce2f in lucene-solr's branch refs/heads/master from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=91fd163 ] LUCENE-7234 : Add InetAddressPoint.nextUp/nextDown
        Hide
        hossman Hoss Man added a comment -

        Manually correcting fixVersion per Step #S5 of LUCENE-7271

        Show
        hossman Hoss Man added a comment - Manually correcting fixVersion per Step #S5 of LUCENE-7271

          People

          • Assignee:
            jpountz Adrien Grand
            Reporter:
            jpountz Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development