Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7187

Block join queries' weight impl should implement extractTerms(...)

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.1, 6.0.1, 5.5.2, 5.6
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      In the case the distribute document frequencies need to be computed for block join queries, the child query is ignored.

      1. LUCENE_7187.patch
        4 kB
        Martijn van Groningen

        Activity

        Hide
        martijn.v.groningen Martijn van Groningen added a comment -

        Attached patch that changes the block join queries to delegate to the child queries extractTerms(...)

        Show
        martijn.v.groningen Martijn van Groningen added a comment - Attached patch that changes the block join queries to delegate to the child queries extractTerms(...)
        Hide
        dsmiley David Smiley added a comment -

        +1

        Show
        dsmiley David Smiley added a comment - +1
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 36a48e4df705d0fb44448805897c63352d00e32f in lucene-solr's branch refs/heads/branch_6_0 from Martijn van Groningen
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=36a48e4 ]

        LUCENE-7187: Block join queries' Weight#extractTerms(...) implementations should delegate to the wrapped weight.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 36a48e4df705d0fb44448805897c63352d00e32f in lucene-solr's branch refs/heads/branch_6_0 from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=36a48e4 ] LUCENE-7187 : Block join queries' Weight#extractTerms(...) implementations should delegate to the wrapped weight.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f18cb90104a0e55f91ce75d726cb489eb5cbf258 in lucene-solr's branch refs/heads/branch_6x from Martijn van Groningen
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f18cb90 ]

        LUCENE-7187: Block join queries' Weight#extractTerms(...) implementations should delegate to the wrapped weight.

        Show
        jira-bot ASF subversion and git services added a comment - Commit f18cb90104a0e55f91ce75d726cb489eb5cbf258 in lucene-solr's branch refs/heads/branch_6x from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f18cb90 ] LUCENE-7187 : Block join queries' Weight#extractTerms(...) implementations should delegate to the wrapped weight.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d7867b80f83beb0d30c5341f2a9d3ab6a35d70c7 in lucene-solr's branch refs/heads/master from Martijn van Groningen
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d7867b8 ]

        LUCENE-7187: Block join queries' Weight#extractTerms(...) implementations should delegate to the wrapped weight.

        Show
        jira-bot ASF subversion and git services added a comment - Commit d7867b80f83beb0d30c5341f2a9d3ab6a35d70c7 in lucene-solr's branch refs/heads/master from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d7867b8 ] LUCENE-7187 : Block join queries' Weight#extractTerms(...) implementations should delegate to the wrapped weight.
        Hide
        martijn.v.groningen Martijn van Groningen added a comment -

        thanks, David!

        Show
        martijn.v.groningen Martijn van Groningen added a comment - thanks, David!
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk close issues included in the 6.0.1 release.

        Show
        steve_rowe Steve Rowe added a comment - Bulk close issues included in the 6.0.1 release.
        Hide
        steve_rowe Steve Rowe added a comment -

        Reopening to backport to 5.6 & 5.5.2.

        Show
        steve_rowe Steve Rowe added a comment - Reopening to backport to 5.6 & 5.5.2.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 93fcdec815e5f22572b34c798ad19c21872daad8 in lucene-solr's branch refs/heads/branch_5_5 from Martijn van Groningen
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=93fcdec ]

        LUCENE-7187: Block join queries' Weight#extractTerms(...) implementations should delegate to the wrapped weight.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 93fcdec815e5f22572b34c798ad19c21872daad8 in lucene-solr's branch refs/heads/branch_5_5 from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=93fcdec ] LUCENE-7187 : Block join queries' Weight#extractTerms(...) implementations should delegate to the wrapped weight.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1c88077132cf04710b22aea150b5a002763ceb1c in lucene-solr's branch refs/heads/branch_5x from Martijn van Groningen
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1c88077 ]

        LUCENE-7187: Block join queries' Weight#extractTerms(...) implementations should delegate to the wrapped weight.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1c88077132cf04710b22aea150b5a002763ceb1c in lucene-solr's branch refs/heads/branch_5x from Martijn van Groningen [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1c88077 ] LUCENE-7187 : Block join queries' Weight#extractTerms(...) implementations should delegate to the wrapped weight.

          People

          • Assignee:
            Unassigned
            Reporter:
            martijn.v.groningen Martijn van Groningen
          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development