Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7145

We need only one set of polygon util methods

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 6.1, 7.0
    • None
    • None
    • New

    Description

      LatLonPoint methods are calling *precise() methods such as rectCrossesPolyPrecise(). GeoPointMethods are calling *approx() methods such as rectCrossesPolyApprox().

      I don't understand why we have two versions of these methods, why one is approximate, why we would ever use that, etc.

      These geo methods are extremely expensive: we can't afford two copies. For example, in the case of these polygon methods, they are still missing direct tests. We need to remove one copy of these. I propose to remove the approx ones.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              rcmuir Robert Muir
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: