Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7126

GeoPointDistanceRangeQuery not valid for multi-valued docs

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0, 6.1, master (7.0)
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This query currently takes minimum and maximum range and rewrites to a boolean query of two distance queries (big NOT little).

      The problem is, this rewrite is not correct if a document has multiple values in the field.

      Do we really need to support this query? What is the use case? Is it a relic of people doing things like pagination or distance faceting in a very slow way? We can do these things more efficiently with other mechanisms (e.g. distance sort for LatLonPoint works well with searchAfter, can be ported to geopoint).

        Activity

        Hide
        mikemccand Michael McCandless added a comment -

        Whoa, that's a good catch. +1 to remove it.

        Show
        mikemccand Michael McCandless added a comment - Whoa, that's a good catch. +1 to remove it.
        Hide
        nknize Nicholas Knize added a comment -

        It was there to support the doughnut search use-case. The other problem with this boolean rewrite is that it visit ranges twice. Super inefficient. I was going to update the GeoAPIs to accept a min/max to solve this, but I agree, this just adds unnecessary complexity. +100 for removing it and accomplishing the doughnut search using a distance sort.

        Show
        nknize Nicholas Knize added a comment - It was there to support the doughnut search use-case. The other problem with this boolean rewrite is that it visit ranges twice. Super inefficient. I was going to update the GeoAPIs to accept a min/max to solve this, but I agree, this just adds unnecessary complexity. +100 for removing it and accomplishing the doughnut search using a distance sort.
        Hide
        mikemccand Michael McCandless added a comment -

        +1

        Show
        mikemccand Michael McCandless added a comment - +1
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9a08113a53f0f526c66e1915423fb17809871995 in lucene-solr's branch refs/heads/master from Robert Muir
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9a08113 ]

        LUCENE-7126: GeoPointDistanceRangeQuery not valid for multi-valued docs

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9a08113a53f0f526c66e1915423fb17809871995 in lucene-solr's branch refs/heads/master from Robert Muir [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9a08113 ] LUCENE-7126 : GeoPointDistanceRangeQuery not valid for multi-valued docs
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d8dd06f422614961b029384c379e96a732fd7476 in lucene-solr's branch refs/heads/branch_6x from Robert Muir
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d8dd06f ]

        LUCENE-7126: GeoPointDistanceRangeQuery not valid for multi-valued docs

        Show
        jira-bot ASF subversion and git services added a comment - Commit d8dd06f422614961b029384c379e96a732fd7476 in lucene-solr's branch refs/heads/branch_6x from Robert Muir [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d8dd06f ] LUCENE-7126 : GeoPointDistanceRangeQuery not valid for multi-valued docs
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8b9ce1cfd02f099826cff5250c90b045219044ff in lucene-solr's branch refs/heads/branch_6_0 from Robert Muir
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8b9ce1c ]

        LUCENE-7126: GeoPointDistanceRangeQuery not valid for multi-valued docs

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8b9ce1cfd02f099826cff5250c90b045219044ff in lucene-solr's branch refs/heads/branch_6_0 from Robert Muir [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8b9ce1c ] LUCENE-7126 : GeoPointDistanceRangeQuery not valid for multi-valued docs
        Hide
        hossman Hoss Man added a comment -

        Manually correcting fixVersion per Step #S6 of LUCENE-7271

        Show
        hossman Hoss Man added a comment - Manually correcting fixVersion per Step #S6 of LUCENE-7271

          People

          • Assignee:
            Unassigned
            Reporter:
            rcmuir Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development