[LUCENE-7077] fail precommit on useless assignment

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.1, 7.0
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 08/Mar/16 02:13
• Updated: 28/Aug/22 14:51
• Resolved: 08/Mar/16 11:48

Description

I found LUCENE-7073 because of a compiler warning in my IDE. It slipped all the way through buggy tests too! I think we should fail when "assignment has no effect", rather than just rely on someone to catch it visually.

This is very specific and will not trigger a bunch of false positives: but can indicate a common bug in e.g. constructors for POJO classes and so on.

Issue Links

• relates to: LUCENE-7746 precommit to ignore less and (potentially) error more