[LUCENE-6999] Lucene60PointsWriter has a buggy close method

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.0
• Lucene Fields: New
• Assignee: Michael McCandless
• Reporter: Robert Muir
• Created: 28/Jan/16 06:32
• Updated: 28/Aug/22 14:49
• Resolved: 28/Jan/16 16:03

Description

This will leak a file handle on e.g. disk full or other exceptions

  @Override
  public void close() throws IOException {
    if (closed == false) {
      CodecUtil.writeFooter(dataOut); // something bad happens
      dataOut.close();

I'm not a fan of these complex close methods, should we add a finish() to the codec api or similar?