[LUCENE-6902] Fail fsync immediately

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.3.1
• Fix Version/s: 5.4, 6.0
• Component/s: core/store
• Lucene Fields: New, Patch Available
• Assignee: Uwe Schindler
• Reporter: Daniel Mitterdorfer
• Created: 19/Nov/15 16:31
• Updated: 28/Aug/22 14:46
• Resolved: 22/Nov/15 10:29

Description

While analysing a build issue in Elasticsearch I stumpled upon org.apache.lucene.util.IOUtils.fsync. It has a retry loop in fsync whenever an IOException occurs. However, there are lots of instances where a retry is not useful, e.g. when a channel has been closed, a ClosedChannelException is thrown and IOUtils#fsync still tries to fsync multiple times on the closed channel.

After bringing the issue to Robert's attention, he even opted for removing the retry logic entirely for fsyncing.

Please find attached a patch that removes the retry logic.