[LUCENE-6898] Avoid reading last stored field value when StoredFieldVisitor.Status.NO

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 5.4
• Component/s: core/codecs
• Lucene Fields: New
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 17/Nov/15 17:37
• Updated: 28/Aug/22 14:46
• Resolved: 20/Nov/15 01:16

Description

CompressingStoredFieldsReader.visitDocument (line 597) loops through the fields in the input while consulting the StoredFieldVisitor on what to do. There is a small optimization that could be done on the last loop iteration. If the visitor returns Status.NO then it should be treated as equivalent to Status.STOP. As it is now, it will call skipField() which reads needless bytes from the DataInput that won't be used.

With this optimization in place, it is advisable to put the largest text field last in sequence – something the user or search platform (e.g. ES/Solr) could do.