[LUCENE-6831] Review LinkedList usage

• Type: Task
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Fix Version/s: 6.0
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Dawid Weiss
• Created: 07/Oct/15 10:12
• Updated: 28/Aug/22 17:43

Description

I quickly scanned the code (out of curiosity) and most of the use cases of LinkedList are as a Queue, in which case indeed an ArrayDeque would be a better choice, especially if the maximum size is known in advance.

There are also some invalid/ incorrect uses like calling size() on a linked list in MultiPhraseQueryNodeBuilder, which should be fixed.

Issue Links

• links to: GitHub Pull Request #1969