Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6652

Remove tons of BytesRefAttribute/BytesRefAttributeImpl duplicates in tests

    Details

    • Type: Test
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.2.1
    • Fix Version/s: 5.3, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      While implementing LUCENE-6651, I found a lot of duplicates of the same class (in different variants) which is used by tests to generate binary terms. As we now have support for binary terms in Field class itsself, we should remove all of those attributes accross tests.

        Issue Links

          Activity

          Hide
          thetaphi Uwe Schindler added a comment -

          This will be fixed through issue LUCENE-6653 (one patch for both).

          Show
          thetaphi Uwe Schindler added a comment - This will be fixed through issue LUCENE-6653 (one patch for both).
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1688830 from Uwe Schindler in branch 'dev/trunk'
          [ https://svn.apache.org/r1688830 ]

          LUCENE-6653, LUCENE-6652: Refactor TermToBytesRefAttribute; add oal.analysis.tokenattributes.BytesTermAttribute; remove code duplication in tests

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1688830 from Uwe Schindler in branch 'dev/trunk' [ https://svn.apache.org/r1688830 ] LUCENE-6653 , LUCENE-6652 : Refactor TermToBytesRefAttribute; add oal.analysis.tokenattributes.BytesTermAttribute; remove code duplication in tests
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1688845 from Uwe Schindler in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1688845 ]

          Merged revision(s) 1688830 from lucene/dev/trunk:
          LUCENE-6653, LUCENE-6652: Refactor TermToBytesRefAttribute; add oal.analysis.tokenattributes.BytesTermAttribute; remove code duplication in tests

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1688845 from Uwe Schindler in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1688845 ] Merged revision(s) 1688830 from lucene/dev/trunk: LUCENE-6653 , LUCENE-6652 : Refactor TermToBytesRefAttribute; add oal.analysis.tokenattributes.BytesTermAttribute; remove code duplication in tests
          Hide
          thetaphi Uwe Schindler added a comment -

          Committed through LUCENE-6653.

          Show
          thetaphi Uwe Schindler added a comment - Committed through LUCENE-6653 .
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Bulk close for 5.3.0 release

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

            People

            • Assignee:
              thetaphi Uwe Schindler
              Reporter:
              thetaphi Uwe Schindler
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development