Lucene - Core
  1. Lucene - Core
  2. LUCENE-6648

Remove dependency of lucene/facet on oal.search.Filter

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Given that Filter is going away, we should stop using it in the facet module.

      1. LUCENE-6648.patch
        69 kB
        Adrien Grand

        Activity

        Hide
        Adrien Grand added a comment -

        Here is a patch. It removes oal.search.Filter usage from lucene/facet and as a side-effect from lucene/demo as well since Filter was only used for facets there.

        This patch is a simple 1:1 migration but we might be able to do better in the future. For instance there are some parts of the code that look like a query being explicitely split into a fast approximation and a slow confirmation (Range.getQuery(fastMatchQuery, ValueSource)) that we might be able to handle more nicely now API-wise?

        Show
        Adrien Grand added a comment - Here is a patch. It removes oal.search.Filter usage from lucene/facet and as a side-effect from lucene/demo as well since Filter was only used for facets there. This patch is a simple 1:1 migration but we might be able to do better in the future. For instance there are some parts of the code that look like a query being explicitely split into a fast approximation and a slow confirmation ( Range.getQuery(fastMatchQuery, ValueSource) ) that we might be able to handle more nicely now API-wise?
        Hide
        Michael McCandless added a comment -

        +1, thanks @jpountz!

        We can do a more clean 2-phase cutover in the future...

        Show
        Michael McCandless added a comment - +1, thanks @jpountz! We can do a more clean 2-phase cutover in the future...
        Hide
        ASF subversion and git services added a comment -

        Commit 1688661 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1688661 ]

        LUCENE-6648: Remove usage of oal.search.Filter in lucene/facet.

        Show
        ASF subversion and git services added a comment - Commit 1688661 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1688661 ] LUCENE-6648 : Remove usage of oal.search.Filter in lucene/facet.
        Hide
        ASF subversion and git services added a comment -

        Commit 1688672 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1688672 ]

        LUCENE-6648: Remove usage of oal.search.Filter in lucene/facet.

        Show
        ASF subversion and git services added a comment - Commit 1688672 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1688672 ] LUCENE-6648 : Remove usage of oal.search.Filter in lucene/facet.
        Hide
        Adrien Grand added a comment -

        Thanks Mike for the review!

        Show
        Adrien Grand added a comment - Thanks Mike for the review!
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            Adrien Grand
            Reporter:
            Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development