[LUCENE-6602] Null value dereference

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 6.0
• Component/s: modules/queryparser
• Labels: github-pullrequest
• Lucene Fields: New, Patch Available
• Assignee: Unassigned
• Reporter: Rishabh Patel
• Created: 24/Jun/15 19:06
• Updated: 28/Aug/22 14:36

Description

In the file BoostQueryNode.java, getChild could be null and it is being dereferenced in the function toString().

BoostQueryNode.java

  public QueryNode getChild() {
    List<QueryNode> children = getChildren();

    if (children == null || children.size() == 0) {
      return null;
    }

    return children.get(0);

  }

BoostQueryNode.java

public String toString() {
    return "<boost value='" + getValueString() + "'>" + "\n"
        + getChild().toString() + "\n</boost>";
  }

Should we not check if getChild is valid?

Probable fix

String s = (getChild() != null) ? getChild().toString() : "null";
return "<boost value='" + getValueString() + "'>" + "\n"
        + s + "\n</boost>";