Lucene - Core
  1. Lucene - Core
  2. LUCENE-6559

TimeLimitingCollector should check timeout also when LeafCollector is pulled

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.2
    • Fix Version/s: 5.2.1, 5.3, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      TimeLimitingCollector only check the timeout if there is actually a hit. If you never hit anything but have a damn slow query for whatever reason the timeout is never hit.

      1. LUCENE-6559.patch
        2 kB
        Simon Willnauer
      2. LUCENE-6559.patch
        2 kB
        Simon Willnauer

        Activity

        Hide
        Simon Willnauer added a comment -

        here is a simple fix and a test

        Show
        Simon Willnauer added a comment - here is a simple fix and a test
        Hide
        Michael McCandless added a comment -

        +1

        But I think you don't need to call myHc.setSlowDown(SLOW_DOWN); since no hits are actually collected...

        Show
        Michael McCandless added a comment - +1 But I think you don't need to call myHc.setSlowDown(SLOW_DOWN); since no hits are actually collected...
        Hide
        Simon Willnauer added a comment -

        new patch fixing the test - I think it's ready

        Show
        Simon Willnauer added a comment - new patch fixing the test - I think it's ready
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Uwe Schindler added a comment -

        +1

        Show
        Uwe Schindler added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1685507 from Simon Willnauer in branch 'dev/trunk'
        [ https://svn.apache.org/r1685507 ]

        LUCENE-6559: TimeLimitingCollector should check timeout also when LeafCollector is pulled

        Show
        ASF subversion and git services added a comment - Commit 1685507 from Simon Willnauer in branch 'dev/trunk' [ https://svn.apache.org/r1685507 ] LUCENE-6559 : TimeLimitingCollector should check timeout also when LeafCollector is pulled
        Hide
        ASF subversion and git services added a comment -

        Commit 1685511 from Simon Willnauer in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1685511 ]

        LUCENE-6559: TimeLimitingCollector should check timeout also when LeafCollector is pulled

        Show
        ASF subversion and git services added a comment - Commit 1685511 from Simon Willnauer in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1685511 ] LUCENE-6559 : TimeLimitingCollector should check timeout also when LeafCollector is pulled
        Hide
        ASF subversion and git services added a comment -

        Commit 1685512 from Simon Willnauer in branch 'dev/branches/lucene_solr_5_2'
        [ https://svn.apache.org/r1685512 ]

        LUCENE-6559: TimeLimitingCollector should check timeout also when LeafCollector is pulled

        Show
        ASF subversion and git services added a comment - Commit 1685512 from Simon Willnauer in branch 'dev/branches/lucene_solr_5_2' [ https://svn.apache.org/r1685512 ] LUCENE-6559 : TimeLimitingCollector should check timeout also when LeafCollector is pulled
        Hide
        ASF subversion and git services added a comment -

        Commit 1685730 from Simon Willnauer in branch 'dev/trunk'
        [ https://svn.apache.org/r1685730 ]

        LUCENE-6559: Fix test, last collected doc can now be unknown

        Show
        ASF subversion and git services added a comment - Commit 1685730 from Simon Willnauer in branch 'dev/trunk' [ https://svn.apache.org/r1685730 ] LUCENE-6559 : Fix test, last collected doc can now be unknown
        Hide
        ASF subversion and git services added a comment -

        Commit 1685731 from Simon Willnauer in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1685731 ]

        LUCENE-6559: Fix test, last collected doc can now be unknown

        Show
        ASF subversion and git services added a comment - Commit 1685731 from Simon Willnauer in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1685731 ] LUCENE-6559 : Fix test, last collected doc can now be unknown
        Hide
        ASF subversion and git services added a comment -

        Commit 1685732 from Simon Willnauer in branch 'dev/branches/lucene_solr_5_2'
        [ https://svn.apache.org/r1685732 ]

        LUCENE-6559: Fix test, last collected doc can now be unknown

        Show
        ASF subversion and git services added a comment - Commit 1685732 from Simon Willnauer in branch 'dev/branches/lucene_solr_5_2' [ https://svn.apache.org/r1685732 ] LUCENE-6559 : Fix test, last collected doc can now be unknown

          People

          • Assignee:
            Simon Willnauer
            Reporter:
            Simon Willnauer
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development