Lucene - Core
  1. Lucene - Core
  2. LUCENE-6538

Improve per-segment diagnostics for IBM J9 JVM

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3, 6.0
    • Component/s: None
    • Labels:
    • Lucene Fields:
      New

      Description

      Spinoff from http://lucene.markmail.org/thread/dq4wioomu4o346ej where I noticed that the per-segment diagnostics (seen from CheckIndex) only report 1.7.0 as the JVM version, without any update level.

      Talking to Robert Muir it looks like we just need to add java.vm.version and java.runtime.version sysprops into the diagnostics.

      1. LUCENE-6538.patch
        2 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        Here's a patch, I just blindly add those two sysprops, but I don't yet have a working J9 to confirm these produce better results than what we add to diagnostics now ...

        Show
        Michael McCandless added a comment - Here's a patch, I just blindly add those two sysprops, but I don't yet have a working J9 to confirm these produce better results than what we add to diagnostics now ...
        Hide
        Robert Muir added a comment -

        do we really need addSysPropIfNotNull(diagnostics, "java.vm.version") ?

        Why not just this:

        diagnostics.add(.., System.getProperty("java.vm.version", "undefined"));
        
        Show
        Robert Muir added a comment - do we really need addSysPropIfNotNull(diagnostics, "java.vm.version") ? Why not just this: diagnostics.add(.., System .getProperty( "java.vm.version" , "undefined" ));
        Hide
        Michael McCandless added a comment -

        Why not just this:

        Oh, duh, much better, I'll fix

        Show
        Michael McCandless added a comment - Why not just this: Oh, duh, much better, I'll fix
        Hide
        Robert Muir added a comment -

        Here is the output of the patch with IBM JDK (ant test -Dtestcase=TestDemo -Dtests.verbose=true):

        diagnostics = {java.runtime.version=pxa6480sr1-20150417_01 (SR1), java.vendor=IBM Corporation, java.version=1.8.0, 
                               java.vm.version=2.8, lucene.version=6.0.0, os=Linux, os.arch=amd64, os.version=3.13.0-49-generic,
                               source=flush, timestamp=1434092680732}
        

        Here is the output with Oracle JDK:

        diagnostics = {java.runtime.version=1.8.0_45-b14, java.vendor=Oracle Corporation, java.version=1.8.0_45, 
                               java.vm.version=25.45-b02, lucene.version=6.0.0, os=Linux, os.arch=amd64, os.version=3.13.0-49-generic, 
                               source=flush, timestamp=1434092969159}
        
        Show
        Robert Muir added a comment - Here is the output of the patch with IBM JDK (ant test -Dtestcase=TestDemo -Dtests.verbose=true): diagnostics = {java.runtime.version=pxa6480sr1-20150417_01 (SR1), java.vendor=IBM Corporation, java.version=1.8.0, java.vm.version=2.8, lucene.version=6.0.0, os=Linux, os.arch=amd64, os.version=3.13.0-49-generic, source=flush, timestamp=1434092680732} Here is the output with Oracle JDK: diagnostics = {java.runtime.version=1.8.0_45-b14, java.vendor=Oracle Corporation, java.version=1.8.0_45, java.vm.version=25.45-b02, lucene.version=6.0.0, os=Linux, os.arch=amd64, os.version=3.13.0-49-generic, source=flush, timestamp=1434092969159}
        Hide
        Michael McCandless added a comment -

        Thanks for testing this Robert Muir; this looks like an improvement?

        Show
        Michael McCandless added a comment - Thanks for testing this Robert Muir ; this looks like an improvement?
        Hide
        ASF subversion and git services added a comment -

        Commit 1685121 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1685121 ]

        LUCENE-6538: improve per-segment diagnostics for IBM's J9 JVM

        Show
        ASF subversion and git services added a comment - Commit 1685121 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1685121 ] LUCENE-6538 : improve per-segment diagnostics for IBM's J9 JVM
        Hide
        ASF subversion and git services added a comment -

        Commit 1685122 from Michael McCandless in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1685122 ]

        LUCENE-6538: improve per-segment diagnostics for IBM's J9 JVM

        Show
        ASF subversion and git services added a comment - Commit 1685122 from Michael McCandless in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1685122 ] LUCENE-6538 : improve per-segment diagnostics for IBM's J9 JVM
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development