Lucene - Core
  1. Lucene - Core
  2. LUCENE-6330

BooleanScorer should not call score() when scores are not needed

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      BooleanScorer (and maybe others?) still call score() when scores are not needed. While this does not make results wrong, it is sub-optimal since it still forces to decode norms while they are not needed.

        Activity

        Hide
        Adrien Grand added a comment -

        Here is a patch, it makes BS1 wrap sub scorers similarly to ConstantScoreQuery's BulkScorer when scores are not needed so that calling score on sub scorers (which it does for every document) does not need to eg. decode norms.

        Show
        Adrien Grand added a comment - Here is a patch, it makes BS1 wrap sub scorers similarly to ConstantScoreQuery's BulkScorer when scores are not needed so that calling score on sub scorers (which it does for every document) does not need to eg. decode norms.
        Hide
        Robert Muir added a comment -

        +1

        Show
        Robert Muir added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1676718 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1676718 ]

        LUCENE-6330: BS1 should not decode norms when scores are not needed.

        Show
        ASF subversion and git services added a comment - Commit 1676718 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1676718 ] LUCENE-6330 : BS1 should not decode norms when scores are not needed.
        Hide
        ASF subversion and git services added a comment -

        Commit 1676720 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1676720 ]

        LUCENE-6330: BS1 should not decode norms when scores are not needed.

        Show
        ASF subversion and git services added a comment - Commit 1676720 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1676720 ] LUCENE-6330 : BS1 should not decode norms when scores are not needed.
        Hide
        Anshum Gupta added a comment -

        Bulk close for 5.2.0.

        Show
        Anshum Gupta added a comment - Bulk close for 5.2.0.

          People

          • Assignee:
            Adrien Grand
            Reporter:
            Adrien Grand
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development