Lucene - Core
  1. Lucene - Core
  2. LUCENE-6306

Merging of doc values, norms is not abortable

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.10.4
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      When you call IW.rollback, IW asks all running merges to abort, and the merges should periodically check their abort flags (it's a "cooperative" mechanism, like thread interrupting in Java).

      In 5.x/trunk we have a nice clean solution where the Directory checks the abort bit during writes, so the codec doesn't have to bother with this.

      But in 4.x, we have to call MergeState.checkAbort.work, and I noticed that neither DVs nor norms call this.

      Typically this is not a problem since merging DVs and norms is usually fast, but for a very large merge / very many DVs and norm'd fields, it could take non-trivial time to merge.

      1. LUCENE-6306.patch
        3 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        Simple patch, I just check abort when we merge each DV field.

        Show
        Michael McCandless added a comment - Simple patch, I just check abort when we merge each DV field.
        Hide
        Michael McCandless added a comment -

        This is low risk ... I think we should fix for 4.10.4.

        Show
        Michael McCandless added a comment - This is low risk ... I think we should fix for 4.10.4.
        Hide
        Robert Muir added a comment -

        +1

        Show
        Robert Muir added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1662723 from Michael McCandless in branch 'dev/branches/lucene_solr_4_10'
        [ https://svn.apache.org/r1662723 ]

        LUCENE-6306: allow doc values and norms merging to be aborted in IW.rollback

        Show
        ASF subversion and git services added a comment - Commit 1662723 from Michael McCandless in branch 'dev/branches/lucene_solr_4_10' [ https://svn.apache.org/r1662723 ] LUCENE-6306 : allow doc values and norms merging to be aborted in IW.rollback
        Hide
        Michael McCandless added a comment -

        Bulk close for 4.10.4 release

        Show
        Michael McCandless added a comment - Bulk close for 4.10.4 release

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development