Lucene - Core
  1. Lucene - Core
  2. LUCENE-6208

CompoundFileFormat.write() has unnecessary parameter

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Today it's: write(Directory dir, SegmentInfo si, Collection<String> files, IOContext context)

      But 'files' is not needed. its always si.files() because thats all this format is responsible for (e.g. its not an api for /bin/cat).

        Activity

        Hide
        Ryan Ernst added a comment -

        +1

        Show
        Ryan Ernst added a comment - +1
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1655520 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1655520 ]

        LUCENE-6208: Remove unnecessary parameter from CompoundFormat.write

        Show
        ASF subversion and git services added a comment - Commit 1655520 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1655520 ] LUCENE-6208 : Remove unnecessary parameter from CompoundFormat.write
        Hide
        ASF subversion and git services added a comment -

        Commit 1655522 from Robert Muir in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1655522 ]

        LUCENE-6208: Remove unnecessary parameter from CompoundFormat.write

        Show
        ASF subversion and git services added a comment - Commit 1655522 from Robert Muir in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1655522 ] LUCENE-6208 : Remove unnecessary parameter from CompoundFormat.write
        Hide
        Timothy Potter added a comment -

        Bulk close after 5.1 release

        Show
        Timothy Potter added a comment - Bulk close after 5.1 release

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development