Lucene - Core
  1. Lucene - Core
  2. LUCENE-6178

don't score MUST_NOT clauses with BooleanScorer

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Its similar to the conjunction case: we should just use BS2 since it has advance(). Even in the dense case I think its currently better since it avoids calling score() in cases where BS1 calls it redundantly.

      1. LUCENE-6178.patch
        0.7 kB
        Robert Muir

        Activity

        Hide
        Robert Muir added a comment -
                            Task   QPS trunk      StdDev   QPS patch      StdDev                Pct diff
                    OrHighNotLow       99.21      (9.3%)      110.09      (6.2%)   11.0% (  -4% -   29%)
                    OrHighNotMed       78.46      (9.3%)       90.47      (6.0%)   15.3% (   0% -   33%)
                   OrHighNotHigh       24.80      (9.1%)       29.90      (5.8%)   20.5% (   5% -   39%)
                   OrNotHighHigh       33.71      (9.0%)       50.06      (7.0%)   48.5% (  29% -   70%)
                    OrNotHighMed       57.14      (8.6%)      183.47      (8.1%)  221.1% ( 188% -  260%)
                    OrNotHighLow       62.74      (8.4%)      922.24     (40.7%) 1369.9% (1218% - 1549%)
        
        Show
        Robert Muir added a comment - Task QPS trunk StdDev QPS patch StdDev Pct diff OrHighNotLow 99.21 (9.3%) 110.09 (6.2%) 11.0% ( -4% - 29%) OrHighNotMed 78.46 (9.3%) 90.47 (6.0%) 15.3% ( 0% - 33%) OrHighNotHigh 24.80 (9.1%) 29.90 (5.8%) 20.5% ( 5% - 39%) OrNotHighHigh 33.71 (9.0%) 50.06 (7.0%) 48.5% ( 29% - 70%) OrNotHighMed 57.14 (8.6%) 183.47 (8.1%) 221.1% ( 188% - 260%) OrNotHighLow 62.74 (8.4%) 922.24 (40.7%) 1369.9% (1218% - 1549%)
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Adrien Grand added a comment -

        +1

        Show
        Adrien Grand added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1651224 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1651224 ]

        LUCENE-6178: don't score MUST_NOT clauses with BooleanScorer

        Show
        ASF subversion and git services added a comment - Commit 1651224 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1651224 ] LUCENE-6178 : don't score MUST_NOT clauses with BooleanScorer
        Hide
        ASF subversion and git services added a comment -

        Commit 1651227 from Robert Muir in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1651227 ]

        LUCENE-6178: don't score MUST_NOT clauses with BooleanScorer

        Show
        ASF subversion and git services added a comment - Commit 1651227 from Robert Muir in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1651227 ] LUCENE-6178 : don't score MUST_NOT clauses with BooleanScorer
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development