[LUCENE-6151] Remove Java 7 close() hack in OutputStreamIndexOutput

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 6.0
• Fix Version/s: 6.0
• Lucene Fields: New
• Assignee: Uwe Schindler
• Reporter: Uwe Schindler
• Created: 31/Dec/14 13:43
• Updated: 28/Aug/22 14:22
• Resolved: 31/Dec/14 14:21

Description

In OutputStreamIndexOutput we have the following hack:

  @Override
  public void close() throws IOException {
    try (final OutputStream o = os) {
      // We want to make sure that os.flush() was running before close:
      // BufferedOutputStream may ignore IOExceptions while flushing on close().
      // TODO: this is no longer an issue in Java 8:
      // http://hg.openjdk.java.net/jdk8/tl/jdk/rev/759aa847dcaf
      o.flush();
    }
  }

As we are on Java 8 already in trunk, we can remove this hack. The bug was fixed in Java 8, BufferedOutputStream / FilterOutputStream always calls flush() and close(), although an error happened!

Issue Links

• is superceded by: LUCENE-6152 Fix double close bug in OutputStreamIndexOutput