[LUCENE-5919] More carefully handle exceptions from IndexFileDeleter.decRef

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.9.1, 4.10.1, 5.0, 6.0
• Component/s: core/index
• Lucene Fields: New
• Assignee: Michael McCandless
• Reporter: Michael McCandless
• Created: 03/Sep/14 08:39
• Updated: 28/Aug/22 14:15
• Resolved: 19/Sep/14 12:03

Description

From test failure: https://builds.apache.org/job/Lucene-Solr-NightlyTests-trunk/613/

java.lang.AssertionError: TEST-TestIndexWriterOutOfMemory.testBasics-seed#[C4C9D7B4B9D5D290]: RefCount is 0 pre-decrement for file "_2_2_Lucene410_0.dvd"
	at __randomizedtesting.SeedInfo.seed([C4C9D7B4B9D5D290:F9117998813B8CE0]:0)
	at org.apache.lucene.index.IndexFileDeleter$RefCount.DecRef(IndexFileDeleter.java:725)
	at org.apache.lucene.index.IndexFileDeleter.decRef(IndexFileDeleter.java:611)
	at org.apache.lucene.index.IndexFileDeleter.decRef(IndexFileDeleter.java:599)
	at org.apache.lucene.index.IndexWriter.prepareCommitInternal(IndexWriter.java:2851)
	at org.apache.lucene.index.IndexWriter.commitInternal(IndexWriter.java:2952)
	at org.apache.lucene.index.IndexWriter.commit(IndexWriter.java:2919)
	at org.apache.lucene.index.TestIndexWriterOutOfMemory.testBasics(TestIndexWriterOutOfMemory.java:215)

Reproduce with: ant test  -Dtestcase=TestIndexWriterOutOfMemory -Dtests.method=testBasics -Dtests.seed=C4C9D7B4B9D5D290 -Dtests.multiplier=2 -Dtests.nightly=true -Dtests.slow=true -Dtests.linedocsfile=/home/jenkins/lucene-data/enwiki.random.lines.txt -Dtests.locale=mk_MK -Dtests.timezone=America/Vancouver -Dtests.file.encoding=ISO-8859-1

What happened was IW was trying to decRef a set of files, and at
least one needed to be deleted, then virus checker threw exception,
and IW later passed the full set of files back to decRef later despite
that some had already been decRef'd the first time.