Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5841

Remove FST.Builder.FreezeTail interface

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 4.10, 6.0
    • core/codecs
    • None
    • New

    Description

      The FST Builder has a crazy-hairy interface called FreezeTail, which is only
      used by BlockTreeTermsWriter to find appropriate prefixes
      (i.e. containing enough terms or sub-blocks) to write term blocks.

      But this is really a silly abuse ... it's cleaner and likely
      faster/less GC for BTTW to compute this itself just by tracking the
      term ordinal where each prefix started in the pending terms/blocks. The
      code is also insanely hairy, and this is at least a baby step to try
      to make it a bit simpler.

      This also makes it very hard to experiment with different formats at
      write-time because you have to get your new formats working through
      this strange FreezeTail.

      Attachments

        1. LUCENE-5841.patch
          139 kB
          Michael McCandless
        2. LUCENE-5841.patch
          135 kB
          Michael McCandless

        Activity

          People

            mikemccand Michael McCandless
            mikemccand Michael McCandless
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: